It is currently Wed Sep 08, 2010 9:32 pm




Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 6 posts ] 
[r1248] Zoom 
Author Message

Joined: Wed Mar 24, 2010 1:35 am
Posts: 3
Post [r1248] Zoom

Zooming in and out is a bit off. It should be changed like this:
Code:
Index: Source/Core/Editing/ClassicMode.cs
===================================================================
--- Source/Core/Editing/ClassicMode.cs   (revision 1248)
+++ Source/Core/Editing/ClassicMode.cs   (working copy)
@@ -185,7 +185,7 @@
      public virtual void ZoomIn()
      {
         // Zoom
-         ZoomBy(1.3f);
+         ZoomBy(1.1f);
      }

      // This zooms out
@@ -193,7 +193,7 @@
      public virtual void ZoomOut()
      {
         // Zoom
-         ZoomBy(0.7f);
+         ZoomBy(1/1.1f);
      }

      // This scrolls anywhere


You can keep the factor at 1.3 if you want, but that's a bit too quick for my tastes.


Wed Mar 24, 2010 1:42 am
Profile
Developer

Joined: Fri May 15, 2009 3:45 pm
Posts: 126
Post Re: [r1248] Zoom

Personal preferences are not bugs ;) I guess it'd be nice to have a big stepped zoom and a small stepped zoom (maybe shift + mouse wheel), though.


Wed Mar 24, 2010 6:09 pm
Profile
User avatar

Joined: Sun Jan 04, 2009 4:49 pm
Posts: 543
Post Re: [r1248] Zoom

Or a slider in the preferences dialog to adjust the speed.


Thu Mar 25, 2010 7:39 am
Profile

Joined: Sat Jan 09, 2010 1:11 pm
Posts: 35
Post Re: [r1248] Zoom

boris wrote:
Personal preferences are not bugs ;)

Nah, the bug is not in that he prefers a smaller factor, the bug is this:

Zoom-in factor: 1+x
Zoom-out factor: 1-x
That's not how inverses are made!

You start with a zoom factor of 1. Let's say you zoom in one tic. Zoom factor is now 1.3 * 1, so 1.3. Now you zoom out one tic. Zoom factor is 0.7 * 1.3, so 0.91. Which is not the same as 1...

Zoom-out factor ought to be 1/zoom-in factor, so that the factors remain consistent. So if zoom-in uses 1.3, then zoom-out ought to be 1/1.3.

(I'd suggest a zoom-in factor of 1.25, this way the zoom-out factor is 0.8, and there are no risk of inaccuracies creeping up from loss of precision.)


Thu Mar 25, 2010 12:03 pm
Profile
Developer

Joined: Fri May 15, 2009 3:45 pm
Posts: 126
Post Re: [r1248] Zoom

I propose the following patch (see attachment).

It adds a slider to the preferences menu:

Image

Range is from 10% to 100%, default is 30%. The math fix is included, of course.


You do not have the required permissions to view the files attached to this post.


Sat May 08, 2010 4:45 pm
Profile
User avatar

Joined: Sun Jan 04, 2009 4:49 pm
Posts: 543
Post Re: [r1248] Zoom

Added.


Sun Aug 01, 2010 7:04 pm
Profile
Display posts from previous:  Sort by  
Forum locked This topic is locked, you cannot edit posts or make further replies.  [ 6 posts ] 


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group. Designed by Vjacheslav Trushkin for Free Forums/DivisionCore.